nodes: improve modular cabinet constraints and finishes - #719
nodes: improve modular cabinet constraints and finishes#719sudhir9297 wants to merge 44 commits into
Conversation
Items (e.g. solar panels) can now be placed on sloped roof surfaces. The placement system computes euler rotation from the roof surface normal so items sit flush on the slope instead of going inside. - Add roofStrategy to placement-strategies with enter/move/click/leave - Wire roof:enter/move/click/leave events in the placement coordinator - Add calculateRoofRotation in placement-math using surface normals - Support full 3D cursor rotation for sloped surfaces - Items on roofs are parented to the level with world-space rotation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… github.com:pascalorg/editor
… github.com:pascalorg/editor
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| (node.showPlinth ? node.plinthHeight : 0) + | ||
| node.carcassHeight + | ||
| (node.withCountertop ? node.countertopThickness : 0) | ||
| return Math.max(0.05, ceilingHeight - currentTop) |
There was a problem hiding this comment.
Fill to ceiling overshoots
Medium Severity
cabinetCeilingGap always returns at least 0.05, even when the module already reaches or exceeds the ceiling. Fill to ceiling then sets topFinishHeight to that floor, so the top finish can poke through the ceiling instead of becoming a zero or near-zero closure.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 85476a4. Configure here.
| return stack.length > 0 && stack.every((compartment) => isHoodCompartmentType(compartment.type)) | ||
| } | ||
|
|
||
| function cabinetModuleHeightHandleVisible( |
There was a problem hiding this comment.
Height handle under finish
Low Severity
The new module height handle is placed with cabinetTotalHeight, which excludes topFinishHeight, while local bounds now include the top finish. With Top Cabinet or Trim active, the Y handle sits inside the finish volume instead of above the full composition.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 85476a4. Configure here.
|
|
||
| const stack = stackForCabinet(node) | ||
| const planningRun = node.type === 'cabinet' ? node : parentRun | ||
| const planningReport = planningRun ? validateCabinetRun(planningRun, modules) : null |
There was a problem hiding this comment.
Wall top finish unchecked
Low Severity
Planning checks run validateCabinetRun only on the parent run’s direct modules. Nested wall cabinets—the modules that commonly use Top / Ceiling—are omitted, and selecting a wall child clears parentRun, so top-cabinet-too-short never surfaces for them.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 85476a4. Configure here.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.
There are 6 total unresolved issues (including 3 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c7ab1d9. Configure here.
| CABINET_METRIC_DEFAULTS, | ||
| findLevelAncestorId, | ||
| selectionProxyIdFromMetadata, | ||
| } from '@pascal-app/core' |
There was a problem hiding this comment.
Footprints omit top finish height
Medium Severity
Selection and local bounds now include topFinishHeight for top-cabinet and trim finishes, but floor-placed footprints still size height with cabinetTotalHeight only. Collision and placement checks can treat the upper finish as empty space and allow overlaps with the new ceiling volumes.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit c7ab1d9. Configure here.
| .map((module) => [module.id, MIN_TRIMMED_CORNER_PRESET_WIDTH]), | ||
| ), | ||
| maximumWidth: MAX_CABINET_WIDTH, | ||
| maximumWidthById, |
There was a problem hiding this comment.
Nested leg uses wrong wall axis
High Severity
When reflowing a nested L-leg, wall constraints are taken from the source straight run, then applied as left/right flags while packing the leg’s own local X modules. For a one-wall source, growth direction and slack consumption follow the source lateral axis on the perpendicular leg, so the return can shift or expand along the wrong direction.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit c7ab1d9. Configure here.
| useScene.getState().nodes as Record<AnyNodeId, AnyNode>, | ||
| ), | ||
| }) | ||
| } |
There was a problem hiding this comment.
Fill to ceiling ignores schema max
Low Severity
Fill to ceiling writes cabinetCeilingGap straight into topFinishHeight. That gap is only floored at 0.05 and is not capped at the field’s 1.2 maximum (or the slider max), so taller rooms can produce out-of-range finish heights.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit c7ab1d9. Configure here.
1 participant
What does this PR do?
How to test
bun dev, open the editor, and create a straight modular base-cabinet run with perpendicular walls constraining both ends.bun test packages/nodes/src/cabinet,bun run check-types,bun run check, andbun run build.Screenshots / screen recording
To be added — this is a visual and interactive cabinet-layout change.
Checklist
bun devbun checkto verify)mainbranchNote
Medium Risk
Large changes to cabinet schema versions, run reflow/corner logic, and default dimensions affect saved scenes and layout behavior, though coverage is extensive.
Overview
This PR extends modular kitchen cabinets with metric-first defaults (600 mm depth family), catalog-style dimension profiles, standard widths, reveal presets, and schema fields for top / ceiling finish (
none, stacked top cabinet, or trim/soffit) with matching 3D geometry and bounds.Run layout and presets are reworked: perpendicular-wall slack and eligible neighbor “donors” drive width changes when applying wider appliance presets, while two-wall runs keep their overall extent. L-corner derived runs nest under source runs in the graph; reflow respects the original straight run’s wall constraints (not the leg’s walls), resyncs corner geometry after width changes, and adds broad regression tests for reflow, stacks, and finishes.
Appliance stacks drop automatic filler drawers above fridges; dishwashers and similar transitions fill the carcass height correctly. The editor Build tab gains a Kitchen tile that arms the modular cabinet tool from the catalog. Research docs on ceiling gaps and modular planning are added; graph validation accepts derived L-corner cabinet trees.
Reviewed by Cursor Bugbot for commit c7ab1d9. Bugbot is set up for automated code reviews on this repo. Configure here.